Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframes are not self-closing #973

Merged
merged 1 commit into from
Dec 12, 2024
Merged

iframes are not self-closing #973

merged 1 commit into from
Dec 12, 2024

Conversation

eyeseast
Copy link
Collaborator

Fixes #972

@eyeseast eyeseast requested a review from allanlasser December 12, 2024 22:24
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit dc92ea8
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/675b62a0c3b42c0008ab2060
😎 Deploy Preview https://deploy-preview-973.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 24 (🔴 down 25 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.7% 7638 / 24093
🔵 Statements 31.7% 7638 / 24093
🔵 Functions 47.74% 338 / 708
🔵 Branches 75.73% 1108 / 1463
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/documents/Share.svelte 100% 58.62% 80% 100%
src/lib/components/projects/ProjectShare.svelte 0% 0% 0% 0% 1-97
Generated in workflow #510 for commit dc92ea8 by the Vitest Coverage Report Action

@eyeseast eyeseast merged commit 6801dac into main Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanlasser allanlasser allanlasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated embed code uses self-closing iframe
2 participants
@eyeseast @allanlasser